This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] PATCH: Fix name uniqueness check

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] PATCH: Fix name uniqueness check
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Thu, 27 Sep 2007 17:50:51 +0100
Delivery-date: Thu, 27 Sep 2007 09:51:32 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
Changeset  15124:f5459c358575 altered check_name() in XendDomainInfo so that
it compares domain IDs instead of UUIDs. This breaks a number of things

 - You can no longer use 'xm new' to define a persistent config file for
   a running guest. This breaks the key OS provisioning scenario where
   you boot a kenrel+initrd for the installer, and at the same time define
   a permanent config with pygrub.

 - It lets you define multiple inactive guests with different UUIDs, but  
   the same name because all inactive guests have a domid of None. So you
   can now end up with multiple guests with same name, which is contrary
   to the goal implied by the patch which was name uniqueness.

It is unclear from the original commit logs just what scenario it was trying
to protect against, but the original checking of uniqueness based on UUID 
was correct & is what was used in previous releases XenD.

Thus the attached patch reverts 15124

   Signed-off-by: Daniel P. Berrange <berrange@xxxxxxxxxx>

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Attachment: xen-name-check.patch
Description: Text document

Xen-devel mailing list