This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] Re: [PATCH] [ACM/Xen] Fix policy buffer layout changed with

To: Stefan Berger <stefanb@xxxxxxxxxx>
Subject: [Xen-devel] Re: [PATCH] [ACM/Xen] Fix policy buffer layout changed with XSM
From: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>
Date: Tue, 04 Sep 2007 14:44:51 -0400
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Keir Fraser <keir@xxxxxxxxxxxxx>
Delivery-date: Wed, 05 Sep 2007 08:13:16 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <OF8679C5A1.06A24342-ON8525734C.0066352C-8525734C.0066567B@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OF8679C5A1.06A24342-ON8525734C.0066352C-8525734C.0066567B@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Tue, 2007-09-04 at 14:37 -0400, Stefan Berger wrote:
> "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx> wrote on 09/04/2007
> 02:29:10 PM:
> > On Tue, 2007-09-04 at 10:57 -0400, Stefan Berger wrote:
> > > This fixes a regression due to changes in the policy buffer layout
> > > submitted by the XSM module.
> > > 
> > 
> > Hi Stefan,
> > 
> > This was done to make the ACM magic number the first word in the
> policy
> > file.  This seemed to be the logical choice to afford ACM the
> greatest
> > flexibility for loading policies under XSM.  In principal, under
> XSM, a
> > security module could be capable of loading and parsing policies
> over a
> > range of policy versions. 
> Did you adapt the tools to generate a binary policy in that form? 

Yes, I did, so actually there would be more changes required should we
go forward.  I apologize for the confusion.

> > 
> > Your patch reverts the ACM module to the original form where the
> first
> > word of the policy file is the policy version - which could change
> over
> > time.  This is the general problem of magic numbers. 
> Yes, I changed it back because it was broken, at least it did not
> accept the policy I tried to load. 
If you recompile your policy everything *should* work fine.  If not, let
me know and I'll make it right.

Xen-devel mailing list