This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH][Retry 1] 4/4: cpufreq/PowerNow! in Xen: PowerNow

To: "Langsdorf, Mark" <mark.langsdorf@xxxxxxx>
Subject: Re: [Xen-devel] [PATCH][Retry 1] 4/4: cpufreq/PowerNow! in Xen: PowerNow! changes
From: Rik van Riel <riel@xxxxxxxxxx>
Date: Tue, 04 Sep 2007 13:08:02 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 05 Sep 2007 08:12:45 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1449F58C868D8D4E9C72945771150BDF0207700F@xxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Red Hat, Inc
References: <200708301201.32030.mark.langsdorf@xxxxxxx> <C2FDF44E.15192%Keir.Fraser@xxxxxxxxxxxx> <1449F58C868D8D4E9C72945771150BDF0207700F@xxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20061008)
Langsdorf, Mark wrote:
On 30/8/07 18:01, "Mark Langsdorf" <mark.langsdorf@xxxxxxx> wrote:

Patch 4 covers the changes necessary to the PowerNow! driver
to make it correctly associate shared cores under Xen.
Should we have a copy of that file in powernow-k8-xen.c? Can the patched file work correctly in a native Linux build?

If I need to change one function in driver/cpufreq/cpufreq_ondemand.c (to use Rik's new getidletime platform hypercall), do I need to make an entire new file or can I just add it inline?

#ifdef is no Linux favorite, but it is far better than
cloning a file.

Politics is the struggle between those who want to make their country
the best in the world, and those who believe it already is.  Each group
calls the other unpatriotic.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>
  • Re: [Xen-devel] [PATCH][Retry 1] 4/4: cpufreq/PowerNow! in Xen: PowerNow! changes, Rik van Riel <=