WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit priv

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit privcmd ioctlconversion for 64-b
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Fri, 06 Jul 2007 13:17:03 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Jul 2007 11:15:07 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <468E854E.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <patchbomb.1183674469@localhost> <3833674b6d561e690b49.1183674475@localhost> <468E14E8.76E4.0078.0@xxxxxxxxxx> <1183736659.3008.8.camel@basalt> <468E854E.76E4.0078.0@xxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2007-07-06 at 17:09 +0100, Jan Beulich wrote:
> >>> Hollis Blanchard <hollisb@xxxxxxxxxx> 06.07.07 17:44 >>>
> >> Where does the hypercall argument translation happen? 
> >
> >It happens inside privcmd_hypercall(). See
> >http://xenbits.xensource.com/ext/linux-ppc-2.6.hg?file/04f6ad5d9232/arch/powerpc/platforms/xen/hcall.c
> > 
> >
> >(In that tree, the function is named "arch_privcmd_hypercall".) IA64 and
> >PPC both implement this function now; only x86 is left with #ifdefs in
> >drivers/xen/privcmd/privcmd.c .
> >
> >COMPATIBLE_IOCTL is just about the ioctl itself, not the sub-structures.
> 
> Hmm, I can't really see any structures being translated there, all I see is
> guest handles getting dereferenced. So I'm still unclear where you do the
> 32-bit layout to 64-bit layout conversion, but obviously I must be missing
> something.

Which structures do you think need further conversion?

We've already fixed all the shared structures (e.g. sysctl) to use
explicitly-sized types, so the PowerPC port has always had proper
interfaces. For example, look at the definition of xen_ulong_t on the
different architectures. The x86 interfaces were frozen too early,
cementing this problem for you.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>