WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit priv

To: Jan Beulich <jbeulich@xxxxxxxxxx>
Subject: Re: [XenPPC] Re: [Xen-devel] [PATCH 6 of 6] [XEN][LINUX] Add 32-bit privcmd ioctlconversion for 64-bit kernels
From: Hollis Blanchard <hollisb@xxxxxxxxxx>
Date: Fri, 06 Jul 2007 10:44:19 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Keir Fraser <keir.fraser@xxxxxxxxxxxxx>, xen-ppc-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 06 Jul 2007 08:42:20 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <468E14E8.76E4.0078.0@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: IBM Linux Technology Center
References: <patchbomb.1183674469@localhost> <3833674b6d561e690b49.1183674475@localhost> <468E14E8.76E4.0078.0@xxxxxxxxxx>
Reply-to: Hollis Blanchard <hollisb@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2007-07-06 at 09:09 +0100, Jan Beulich wrote:
> >--- a/fs/compat_ioctl.c        Thu Jul 05 17:25:47 2007 -0500
> >+++ b/fs/compat_ioctl.c        Thu Jul 05 17:26:48 2007 -0500
> >@@ -2948,6 +2953,18 @@ COMPATIBLE_IOCTL(LPRESET)
> > /*LPGETSTATS not implemented, but no kernels seem to compile it in
> anyways*/
> > COMPATIBLE_IOCTL(LPGETFLAGS)
> > HANDLE_IOCTL(LPSETTIMEOUT, lp_timeout_trans)
> >+
> >+#ifdef CONFIG_XEN
> >+HANDLE_IOCTL(IOCTL_PRIVCMD_MMAP_32, privcmd_ioctl_32)
> >+HANDLE_IOCTL(IOCTL_PRIVCMD_MMAPBATCH_32, privcmd_ioctl_32)
> >+COMPATIBLE_IOCTL(IOCTL_PRIVCMD_HYPERCALL)
> 
> Where does the hypercall argument translation happen? 

It happens inside privcmd_hypercall(). See
http://xenbits.xensource.com/ext/linux-ppc-2.6.hg?file/04f6ad5d9232/arch/powerpc/platforms/xen/hcall.c

(In that tree, the function is named "arch_privcmd_hypercall".) IA64 and
PPC both implement this function now; only x86 is left with #ifdefs in
drivers/xen/privcmd/privcmd.c .

COMPATIBLE_IOCTL is just about the ioctl itself, not the sub-structures.

-- 
Hollis Blanchard
IBM Linux Technology Center


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>