WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds

To: Dave Lively <dlively@xxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Wed, 06 Jun 2007 19:57:37 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 06 Jun 2007 11:55:52 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1b64e7ec0706061142h4d81c7admc90973924826f94b@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceobIx4y0AxgBRfEdyEZAAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
User-agent: Microsoft-Entourage/11.3.3.061214
On 6/6/07 19:42, "Dave Lively" <dlively@xxxxxxxxxxxxxxx> wrote:

> I've also separated this x86_64 case from the i386 case.  We end up
> including the same file
> (unmodified_drivers/linux-2.6/compat-include/asm-generic/pgtable-nopud.h)
> in either case, but it was pretty confusing the way I had it mixed in
> with the i386 case.

In the patch it's pgtable-nopmd.h. But pgtable-nopud.h makes more sense
(x86/64 Linux has always had proper pmds). So is the patch incorrect?

Also, this could be placed inside asm-x86_64/mach-xen/asm/hypervisor.h,
couldn't it?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel