WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds

To: "Keir Fraser" <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] [HVM] Fix 64 bit PV-on-HVM driver builds
From: "Dave Lively" <dlively@xxxxxxxxxxxxxxx>
Date: Wed, 6 Jun 2007 14:42:11 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Wed, 06 Jun 2007 11:40:17 -0700
Dkim-signature: a=rsa-sha1; c=relaxed/relaxed; d=gmail.com; s=beta; h=domainkey-signature:received:received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=CH3HoskD5x2oHFyC6Ka9s3wSM/p8t0EgKPDLxalrrq7LjGkOs9NX/VGfbuj6LcbmwzpvGm2VRvbV7bYzB2Mc8j58H9RyEViRPXqmo7m3q1t/Z+hk31csOa4KZYX6amqr/kFl3X2xADvEgiPVUo6v9VLT8ojVLIP7zU1wKyP4i/8=
Domainkey-signature: a=rsa-sha1; c=nofws; d=gmail.com; s=beta; h=received:message-id:date:from:sender:to:subject:cc:in-reply-to:mime-version:content-type:references:x-google-sender-auth; b=ns6n5RglhGqnZCZecU9cRdLK+Z3IIg+t5BaUsytRBaZg+kUeNiMhV9w5+Gb+BWg7lFHQFMRl9Dpxqrh3MjVKrxjLBfJ+7b/BSVMwifV6sXhbozob/Fku63jrYOn1axLb2zphdLXHYLRXcqqtAuRacyEYh4vchiCMkYa4UcUX1WY=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C28CA1B0.10304%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <4666DC10.9020107@xxxxxxxxxxxxxxx> <C28CA1B0.10304%keir@xxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
After further investigation, I see that the PV-on-HVM driver build was
broken only for x86_64 linux kernels PRIOR TO 2.6.11 (i.e., without a
pud_t typedef).  And my original patch breaks the build with kernels
= 2.6.11.  I had mistakenly thought it was a matter of CONFIG_XEN or
not.  The attached new version of this patch should work with all
(2.6) kernels.  I now test LINUX_VERSION_CODE instead of CONFIG_XEN.

I've also separated this x86_64 case from the i386 case.  We end up
including the same file
(unmodified_drivers/linux-2.6/compat-include/asm-generic/pgtable-nopud.h)
in either case, but it was pretty confusing the way I had it mixed in
with the i386 case.

Tested building against 2.6.5, 2.6.9, and 2.6.18 guest kernels.

Dave

On 6/6/07, Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
This makes no sense. x86/64 drivers build fine for me as is.

 -- Keir


On 6/6/07 17:08, "Ben Guthro" <bguthro@xxxxxxxxxxxxxxx> wrote:

> xenbus-drivers-64bit-build-fix.patch:
> allow unmodified drivers to build under 64 bits
>
> Signed-off-by: David Lively <dlively@xxxxxxxxxxxxxxx>
> diff -r d4a0706d6747
> linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/hypervisor.h
> --- a/linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/hypervisor.h Tue May
> 15 15:14:02 2007 +0100
> +++ b/linux-2.6-xen-sparse/include/asm-i386/mach-xen/asm/hypervisor.h Thu May
> 17 15:01:35 2007 -0400
> @@ -45,13 +45,15 @@
>  #include <xen/interface/nmi.h>
>  #include <asm/ptrace.h>
>  #include <asm/page.h>
> -#if defined(__i386__)
> +
> +#if !defined(CONFIG_XEN) || defined(__i386__)
>  #  ifdef CONFIG_X86_PAE
>  #   include <asm-generic/pgtable-nopud.h>
>  #  else
>  #   include <asm-generic/pgtable-nopmd.h>
>  #  endif
>  #endif
> +
>
>  extern shared_info_t *HYPERVISOR_shared_info;
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@xxxxxxxxxxxxxxxxxxx
> http://lists.xensource.com/xen-devel


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

Attachment: xenbus-drivers-64bit-build-fix.patch
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel