WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

RE: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)

To: "Muli Ben-Yehuda" <muli@xxxxxxxxxx>
Subject: RE: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)
From: "Guy Zana" <guy@xxxxxxxxxxxx>
Date: Mon, 4 Jun 2007 17:48:35 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 04 Jun 2007 14:50:39 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070604182828.GE4556@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acem1iglks0kQKAeRkGe0tbKaAqT9gAGzjuw
Thread-topic: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)
 

> -----Original Message-----
> From: Muli Ben-Yehuda [mailto:muli@xxxxxxxxxx] 
> Sent: Monday, June 04, 2007 9:28 PM
> To: Guy Zana
> Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> Subject: Re: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough 
> (non-IOMMU)
> 
> > +
> > +#ifdef CONFIG_NEO
> > +    p->eip = regs->eip;
> > +    p->cs = regs->cs;
> > +#endif
> 
> For merging it would be good if the CONFIG_XXX bits could go 
> away unless absolutely necessary.

Ok.

> 
> >      p->io_count++;
> >  
> > --- a/xen/include/asm-x86/e820.h    Sat May 05 13:48:05 2007 +0100
> > +++ b/xen/include/asm-x86/e820.h    Thu May 31 21:04:53 2007 +0300
> > @@ -3,13 +3,6 @@
> >  
> >  #include <public/hvm/e820.h>
> >  
> > -#define E820MAX    128
> > -
> > -struct e820map {
> > -    int nr_map;
> > -    struct e820entry map[E820MAX];
> > -};
> > -
> 
> Why does this need to move to hvm/e820.h?

It's more logical this way, all e820 structures on the same file.
I don't have the code in front of me but I think I needed struct e820map in 
libxc.

Thanks,
Guy.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>