WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)

To: Guy Zana <guy@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [RFC][PATCH 2/6] HVM PCI Passthrough (non-IOMMU)
From: Muli Ben-Yehuda <muli@xxxxxxxxxx>
Date: Mon, 4 Jun 2007 21:28:29 +0300
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 04 Jun 2007 11:26:38 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <9392A06CB0FDC847B3A530B3DC174E7B02A95EDE@xxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9392A06CB0FDC847B3A530B3DC174E7B02A95EDE@xxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.11
On Thu, May 31, 2007 at 07:05:01PM -0400, Guy Zana wrote:

> --- a/xen/arch/x86/hvm/platform.c     Sat May 05 13:48:05 2007 +0100
> +++ b/xen/arch/x86/hvm/platform.c     Thu May 31 21:04:53 2007 +0300
> @@ -844,6 +844,9 @@ void send_pio_req(unsigned long port, un
>      struct vcpu *v = current;
>      vcpu_iodata_t *vio;
>      ioreq_t *p;
> +#ifdef CONFIG_NEO
> +    struct cpu_user_regs *regs = &v->arch.hvm_vcpu.io_op.io_context;
> +#endif
>  
>      if ( size == 0 || count == 0 ) {
>          printk("null pio request? port %lx, count %lx, "
> @@ -870,6 +873,11 @@ void send_pio_req(unsigned long port, un
>      p->addr = port;
>      p->count = count;
>      p->df = df;
> +
> +#ifdef CONFIG_NEO
> +    p->eip = regs->eip;
> +    p->cs = regs->cs;
> +#endif

For merging it would be good if the CONFIG_XXX bits could go away
unless absolutely necessary.

>      p->io_count++;
>  
> --- a/xen/include/asm-x86/e820.h      Sat May 05 13:48:05 2007 +0100
> +++ b/xen/include/asm-x86/e820.h      Thu May 31 21:04:53 2007 +0300
> @@ -3,13 +3,6 @@
>  
>  #include <public/hvm/e820.h>
>  
> -#define E820MAX      128
> -
> -struct e820map {
> -    int nr_map;
> -    struct e820entry map[E820MAX];
> -};
> -

Why does this need to move to hvm/e820.h?

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>