WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled

To: Keir Fraser <keir@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Mon, 4 Jun 2007 14:52:20 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Mon, 04 Jun 2007 06:50:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C289D6B9.FF30%keir@xxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20070531213208.GD15661@xxxxxxxxxx> <C289D6B9.FF30%keir@xxxxxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Mon, Jun 04, 2007 at 02:48:25PM +0100, Keir Fraser wrote:
> On 31/5/07 22:32, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote:
> 
> >   * Adds a --pid-file command line argument to override the default
> >     location of pid file (this is not really related to logging, but
> >     since i was in that code...)
> 
> Applied, thanks. But...
> 
> Use of uninitialised local variable pidfile detected by gcc in this patch.
> You guys really should consider using -Werror. It's great. :-)

Opps, we do use -Werror for all formal builds - dunno how that got missed.

> Also, shouldn't the writes to log files be non-blocking, and those fds be
> added to the select set when there is data waiting to be written?

IIRC, if you select() on a local file handle it'll always be shown writable
so I don't believe it'll be any use.

Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel