 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled
| To: | "Daniel P. Berrange" <berrange@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled |
| From: | Keir Fraser <keir@xxxxxxxxxxxxx> |
| Date: | Mon, 04 Jun 2007 14:48:25 +0100 |
| Delivery-date: | Mon, 04 Jun 2007 06:46:36 -0700 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20070531213208.GD15661@xxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
| Thread-index: | AcemrwXKRKPCXhKiEdyEowAX8io7RQ== |
| Thread-topic: | [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled |
| User-agent: | Microsoft-Entourage/11.3.3.061214 |
On 31/5/07 22:32, "Daniel P. Berrange" <berrange@xxxxxxxxxx> wrote: > * Adds a --pid-file command line argument to override the default > location of pid file (this is not really related to logging, but > since i was in that code...) Applied, thanks. But... Use of uninitialised local variable pidfile detected by gcc in this patch. You guys really should consider using -Werror. It's great. :-) Also, shouldn't the writes to log files be non-blocking, and those fds be added to the select set when there is data waiting to be written? -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | Re: [Xen-devel] [1/3] [XEN] gnttab: Add new op unmap_and_replace, Daniel P. Berrange |
|---|---|
| Next by Date: | Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled, Daniel P. Berrange |
| Previous by Thread: | Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled, Keir Fraser |
| Next by Thread: | Re: [Xen-devel] PATCH: Add persistent guest & hv logging in xenconsoled, Daniel P. Berrange |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
