This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shuttin

To: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shutting down
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Fri, 25 May 2007 15:18:28 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 25 May 2007 07:11:36 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20070525130923.GB11489@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <bfd2245773b4772671a5.1180064526@xenbld> <20070525130923.GB11489@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Fri, May 25, 2007 at 02:09:23PM +0100, Daniel P. Berrange wrote:

> > Instead of violently destroying a domain that is not responding to a 
> > shutdown
> > request, rename the domain to indicate the problem and leave it alone; this
> > allows the admin to make corrective actions (which may or may not include
> > destroying the domain).
> Do we really need to rename it ? Various bits of code do uniqueness checks
> on both name & uuid. If we rename it, though uuid checks still work, any such 
> checks on the name will not be correct. IMHO, if shutdown fails we should just
> leave the guest alone completely. The admin knows that they requested a 
> shutdown,
> and can clearly see that after 'n' seconds it is still around & can take the
> appropriate action - admins already know to watch for failed shutdowns since
> this stuff happens on bare metal too. Renaming to 'report' error just seems
> wrong to me & will potentially confuse tools.

Seems like a reasonable argument to me... Keir?


Xen-devel mailing list