This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shuttin

To: john.levon@xxxxxxx
Subject: Re: [Xen-devel] [PATCH] Do not destroy domains that timeout when shutting down
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Fri, 25 May 2007 14:09:23 +0100
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Fri, 25 May 2007 06:07:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <bfd2245773b4772671a5.1180064526@xenbld>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <bfd2245773b4772671a5.1180064526@xenbld>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Thu, May 24, 2007 at 08:42:06PM -0700, john.levon@xxxxxxx wrote:
> # HG changeset patch
> # User john.levon@xxxxxxx
> # Date 1180046767 25200
> # Node ID bfd2245773b4772671a5aa7772ff88554292de34
> # Parent  c7dee061ade1ac0c4ef417ecadd98f048ddece96
> Do not destroy domains that timeout when shutting down
> Instead of violently destroying a domain that is not responding to a shutdown
> request, rename the domain to indicate the problem and leave it alone; this
> allows the admin to make corrective actions (which may or may not include
> destroying the domain).

Do we really need to rename it ? Various bits of code do uniqueness checks
on both name & uuid. If we rename it, though uuid checks still work, any such 
checks on the name will not be correct. IMHO, if shutdown fails we should just
leave the guest alone completely. The admin knows that they requested a 
and can clearly see that after 'n' seconds it is still around & can take the
appropriate action - admins already know to watch for failed shutdowns since
this stuff happens on bare metal too. Renaming to 'report' error just seems
wrong to me & will potentially confuse tools.

|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

Xen-devel mailing list