This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH]: Fix mem= kernel parameter

To: Chris Lalancette <clalance@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH]: Fix mem= kernel parameter
From: Keir Fraser <keir@xxxxxxxxxxxxx>
Date: Tue, 22 May 2007 17:17:24 +0100
Delivery-date: Tue, 22 May 2007 09:15:59 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <4652FD76.1010600@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcecjK577Rdv2Qh/Edy3pQAX8io7RQ==
Thread-topic: [Xen-devel] [PATCH]: Fix mem= kernel parameter
User-agent: Microsoft-Entourage/
We used to support this properly but it must have got dropped during some
kernel upgrade. Thanks for adding it back in.

 -- Keir

On 22/5/07 15:25, "Chris Lalancette" <clalance@xxxxxxxxxx> wrote:

> The third case is the one that is currently broken.   Looking at the code
> above,
> you can see that the array allocated for the p2m table is too small in that
> case, and during the subsequent memcpy() can cause a page fault and then an
> OOPs.  The attached patch handles the third case by decreasing the
> reservation,
> and only copying the appropriate number of entries into the p2m table.

Xen-devel mailing list

<Prev in Thread] Current Thread [Next in Thread>