This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Tue, 08 May 2007 08:14:25 +0100
Cc: "George S. Coker, II" <gscoker@xxxxxxxxxxxxxx>, xense-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 08 May 2007 00:11:10 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200705080421.02253.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AceRQIIZwMkEzP0zEdu8ogAWy6hiGQ==
Thread-topic: [Xen-devel][Xense-devel][PATCH][3/4] Xen Security Modules: tools
User-agent: Microsoft-Entourage/
On 8/5/07 04:21, "Mark Williamson" <mark.williamson@xxxxxxxxxxxx> wrote:

> Same style issues as other patches, but again we need to figure out which of
> the sub-styles of the Xen code we need to standardise on ;-)

There are two styles we properly support: Xen style as in files like
event_channel.c, xmalloc.c, etc.; and Linux style (generally seen in files
ripped off fairly directly from Linux -- *not* used in new files). The
halfway-house files usually arise from me having been too lazy to enforce
Xen style when they were checked in, and generally being in bits of the tree
where I don't often venture.

Seeing as we're planning to be more strict from now on, the current ACM code
style is *not* to be followed.

 -- Keir

Xen-devel mailing list