| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] [PATCH] Segments can span multiple clusters withtap:qcow
|
To: |
Keir Fraser <keir@xxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] [PATCH] Segments can span multiple clusters withtap:qcow |
|
From: |
Mark McLoughlin <markmc@xxxxxxxxxx> |
|
Date: |
Thu, 03 May 2007 18:47:49 +0100 |
|
Cc: |
Jake Wires <Jake.Wires@xxxxxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx> |
|
Delivery-date: |
Thu, 03 May 2007 10:46:27 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<C25FDD27.E5EB%keir@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
Organization: |
Red Hat Ltd. Registered Address: Red Hat Ltd, Brian O' Donnell and Partners, 62 Merrion Square, Dublin 2, Ireland. Registered in the Companies Registration Office, Parnell House, 14 Parnell Square, Dublin 1, Ireland, at No. 304873 Directors: Charlie Peters (USA), Michael Cunningham (USA), Matt Parson (USA), Brendan Lane |
|
References: |
<C25FDD27.E5EB%keir@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Thu, 2007-05-03 at 18:40 +0100, Keir Fraser wrote:
> On 3/5/07 02:06, "Jake Wires" <Jake.Wires@xxxxxxxxxxxxx> wrote:
>
> > This patch is back to only allocating enough requests for one segment:
> >
> > + /* A segment (i.e. a page) can span multiple clusters */
> > + s->max_aio_reqs = (getpagesize() / s->cluster_size) + 1;
> >
> > In fact, this code allocates exactly two AIO requests for QCoW images
> > created by qcow-create, which have a default cluster size of 4K.
>
> What shall we do -- revert the whole patch or fix this line?
Goodness, words fail me. In all the confusion I created, that fix got
lost again. It should be:
+ s->max_aio_reqs = ((getpagesize() / s->cluster_size) + 1) *
MAX_SEGMENTS_PER_REQ * MAX_REQUESTS;
Thanks,
Mark.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home