Re: [Xen-devel] [PATCH] Segments can span multiple clusters with

To:	Jake Wires <Jake.Wires@xxxxxxxxxxxxx>, Mark McLoughlin <markmc@xxxxxxxxxx>
Subject:	Re: [Xen-devel] [PATCH] Segments can span multiple clusters withtap:qcow
From:	Keir Fraser <keir@xxxxxxxxxxxxx>
Date:	Thu, 03 May 2007 18:40:39 +0100
Cc:	xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date:	Thu, 03 May 2007 10:39:25 -0700
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxx
In-reply-to:	<A9AD3C3BCF83FD4182B7D4D99E37FAD819F840@xxxxxxxxxxxxxxxxxxxxxxxx>
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index:	AceNH0WS/5C6HokBQPS/T4w0JHDITwAiuRQs
Thread-topic:	[Xen-devel] [PATCH] Segments can span multiple clusters withtap:qcow
User-agent:	Microsoft-Entourage/11.3.3.061214

On 3/5/07 02:06, "Jake Wires" <Jake.Wires@xxxxxxxxxxxxx> wrote:

> This patch is back to only allocating enough requests for one segment:
> 
> +        /* A segment (i.e. a page) can span multiple clusters */
> +        s->max_aio_reqs = (getpagesize() / s->cluster_size) + 1;
> 
> In fact, this code allocates exactly two AIO requests for QCoW images
> created by qcow-create, which have a default cluster size of 4K.

What shall we do -- revert the whole patch or fix this line?

 -- Keir


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

WARNING - OLD ARCHIVES

xen-devel

Re: [Xen-devel] [PATCH] Segments can span multiple clusters withtap:qcow