| |
|
 |
|
 |
|
|
|
| |
|
|
xen-devel
Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console
|
To: |
Keir Fraser <keir@xxxxxxxxxxxxx> |
|
Subject: |
Re: [Xen-devel] Re: [patch 21/26] Xen-paravirt_ops: Use the hvc console infrastructure for Xen console |
|
From: |
Andrew Morton <akpm@xxxxxxxxxxxxxxxxxxxx> |
|
Date: |
Fri, 16 Mar 2007 03:41:23 -0800 |
|
Cc: |
xen-devel@xxxxxxxxxxxxxxxxxxx, Andi Kleen <ak@xxxxxx>, linux-kernel@xxxxxxxxxxxxxxx, Keir Fraser <Keir.Fraser@xxxxxxxxxxxxx>, Wright <chrisw@xxxxxxxxxxxx>, virtualization@xxxxxxxxxxxxxx, Chris, Ingo Molnar <mingo@xxxxxxx> |
|
Delivery-date: |
Mon, 19 Mar 2007 03:45:04 -0700 |
|
Envelope-to: |
www-data@xxxxxxxxxxxxxxxxxx |
|
In-reply-to: |
<C2202295.BA49%keir@xxxxxxxxxxxxx> |
|
List-help: |
<mailto:xen-devel-request@lists.xensource.com?subject=help> |
|
List-id: |
Xen developer discussion <xen-devel.lists.xensource.com> |
|
List-post: |
<mailto:xen-devel@lists.xensource.com> |
|
List-subscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
|
List-unsubscribe: |
<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
|
References: |
<20070316095851.GB301@xxxxxxx> <C2202295.BA49%keir@xxxxxxxxxxxxx> |
|
Sender: |
xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On Fri, 16 Mar 2007 10:31:49 +0000 Keir Fraser <keir@xxxxxxxxxxxxx> wrote:
> On 16/3/07 09:58, "Ingo Molnar" <mingo@xxxxxxx> wrote:
>
> >> These mb()'s are pretty standard for lock-free producer/consumer
> >> rings. Write descriptor /then/ write the updated producer. Read the
> >> producer /then/ read any descriptors revealed by this new producer
> >> value.
> >
> > then use rmb()/wmb(). Rarely does a ring protocol truly need mb().
>
> It's needed for writing data /after/ reading the consumer index that shows
> you have space to write. Looking through xenbus_comms.c I think all the
> barriers are correct except there is a spurious extra mb() in xb_read(),
> where there is a later rmb() which is sufficient by itself. All the others
> have a purpose.
>
If Ingo couldn't work this out from reading the code then nobody else can,
and we have a maintainability problem which can only be solved with
adequate commenting.
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
|
|
|
| |
|
Home