Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c

On Mon, 2007-01-22 at 15:08 +0100, Christoph Egger wrote:
> On Monday 22 January 2007 12:57, Ian Campbell wrote:
> > Perhaps you could include the cast in the ELFNOTE_NEXT() macro instead
> > of repeating it everywhere it is used?
> 
> Here we go. Patch attached.

Thanks, applied.

> 
> > Also, could the elfnote macros could be moved to a header? They are used
> > in xen/common/elf.c too.
> 
> They are similar but not equal.

They were roughly equivalent, the one in kexec.c had just further
abstracted ELFNOTE_ALIGN and the one in elf.c had an extra const on
ELFNOTE_NAME.

I moved them into xen/elf.h.

Ian.


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [PATCH] Cleanup for xen/common/kexec.c, Christoph Egger Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c, Ian Campbell Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c, Christoph Egger Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c, Ian Campbell <=

Previous by Date:

[Xen-devel] Re: [Xen-users] xen 3.0.4 and TLS, grg lmb

Next by Date:

[Xen-devel] Re: [Xen-staging] [xen-unstable] [XEN] Avoid void* arithmetic in kexec ELF note manipulations., Jimi Xenidis

Previous by Thread:

Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c, Christoph Egger

Next by Thread:

[Xen-devel] [PATCH] linux/i386: widen physical address range, Jan Beulich

Indexes:

[Date] [Thread] [Top] [All Lists]