WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH] Cleanup for xen/common/kexec.c
From: "Christoph Egger" <Christoph.Egger@xxxxxxx>
Date: Mon, 22 Jan 2007 15:08:34 +0100
Cc: Ian Campbell <Ian.Campbell@xxxxxxxxxxxxx>
Delivery-date: Mon, 22 Jan 2007 06:11:36 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <1169467026.6453.29.camel@xxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: AMD / OSRC
References: <200701221048.53313.Christoph.Egger@xxxxxxx> <1169467026.6453.29.camel@xxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.4
On Monday 22 January 2007 12:57, Ian Campbell wrote:
> On Mon, 2007-01-22 at 10:48 +0100, Christoph Egger wrote:
> >  #define ELFNOTE_ALIGN(_n_) (((_n_)+3)&~3)
> > -#define ELFNOTE_NAME(_n_) ((void*)(_n_) + sizeof(*(_n_)))
> > +#define ELFNOTE_NAME(_n_) ((char*)(_n_) + sizeof(*(_n_)))
> >  #define ELFNOTE_DESC(_n_) (ELFNOTE_NAME(_n_) +
> > ELFNOTE_ALIGN((_n_)->namesz)) #define ELFNOTE_NEXT(_n_)
> > (ELFNOTE_DESC(_n_) + ELFNOTE_ALIGN((_n_)->descsz))
> >
> > @@ -75,10 +75,10 @@ void kexec_crash_save_cpu(void)
> >      if ( cpu_test_and_set(cpu, crash_saved_cpus) )
> >          return;
> >
> > -    prstatus = ELFNOTE_DESC(note);
> > -
> > -    note = ELFNOTE_NEXT(note);
> > -    xencore = ELFNOTE_DESC(note);
> > +    prstatus = (ELF_Prstatus *)ELFNOTE_DESC(note);
> > +
> > +    note = (Elf_Note *)ELFNOTE_NEXT(note);
>
> Perhaps you could include the cast in the ELFNOTE_NEXT() macro instead
> of repeating it everywhere it is used?

Here we go. Patch attached.

> Also, could the elfnote macros could be moved to a header? They are used
> in xen/common/elf.c too.

They are similar but not equal.


Christoph

Attachment: xen_kexec.diff
Description: Text Data

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
<Prev in Thread] Current Thread [Next in Thread>