WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Trivial patch to fix logging level output by XendCheckpo

To: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Subject: Re: [Xen-devel] Trivial patch to fix logging level output by XendCheckpoint.py
From: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Date: Tue, 21 Nov 2006 12:29:36 +0000
Cc: "Graham, Simon" <Simon.Graham@xxxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Tue, 21 Nov 2006 04:29:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20061121092006.GA20850@xxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <342BAC0A5467384983B586A6B0B37671041903AA@xxxxxxxxxxxxxxxxxxxxx> <20061121092006.GA20850@xxxxxxxxxxxxxxxxxxxxxx>
Reply-to: "Daniel P. Berrange" <berrange@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.4.1i
On Tue, Nov 21, 2006 at 09:20:06AM +0000, Ewan Mellor wrote:
> On Mon, Nov 20, 2006 at 08:23:24PM -0500, Graham, Simon wrote:
> 
> > Well, I didn't expect this much discussion!!! I must admit I found it
> > hard to grok this code initially but I think the idea of exec'ing a
> > separate program is a good one to avoid the chance that xend can die
> > (especially since you don't currently seem to be able to restart xend
> > without rebooting Dom0).
> 
> That's not true -- Xend ought to be restarting itself (it forks itself so that
> it has a monitor process) and even then "xend restart" ought to work.  Are you
> having trouble with that?
> 
> The one process that we can't restart at the moment is xenstored.  Everything
> else should be fine.

While XenD itself can easily be restarted it does cause a few problems
if you have any HVM domains, or paravirt + blktap domains running. XenD
is the parent process for both qemu-dm and tapdisk helper processes. It
appears that these two are incapable of detecting shutdown of the guest
they are associated with themselves, and instead rely on XenD to tell
them when to exit / kill them. So the problem is, that if you restart
XenD these processes get re-parented to init, and then when you shutdown
the guest domain, the qemu-dm/tapdisk helpers stay around causing the
domain to linger in zombie state forever.

If we could figure out how to sort this, then XenD would be trivially
restartable without any ill effects.

> > Anyway - even if XendCheckpoint.py called xc_linux_save/restore
> > directly, you'd still have to deal with getting the output to the right
> > place since these APIs write their debug output directly to stderr so
> > I've got to believe you'd still fork a child that made the call and have
> > the parent slurp the contents of stderr and log them so the same issue
> > would exist...
> 
> Yes, I think Daniel was proposing fixing all of that, too.

Yes, the formalized libxc error handling patches would make that unncessary
if the calls were made in-process. Of course I still need to write another
iteration of those patches based on latest round of feedback, so we can put
this issue off to a later date.

Regards,
Dan.
-- 
|=- Red Hat, Engineering, Emerging Technologies, Boston.  +1 978 392 2496 -=|
|=-           Perl modules: http://search.cpan.org/~danberr/              -=|
|=-               Projects: http://freshmeat.net/~danielpb/               -=|
|=-  GnuPG: 7D3B9505   F3C9 553F A1DA 4AC2 5648 23C1 B3DF F742 7D3B 9505  -=| 

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel