WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Linux-specific blkif.py change

To: Brendan Cully <brendan@xxxxxxxxx>
Subject: Re: [Xen-devel] Linux-specific blkif.py change
From: John Levon <levon@xxxxxxxxxxxxxxxxx>
Date: Thu, 2 Nov 2006 02:03:46 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 02 Nov 2006 13:56:42 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <6410E3EF-2671-4BE2-93AE-A64D0CD6F3DD@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20061102014250.GA1575@xxxxxxxxxxxxxxxxxxxx> <6410E3EF-2671-4BE2-93AE-A64D0CD6F3DD@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Wed, Nov 01, 2006 at 06:03:03PM -0800, Brendan Cully wrote:

> >The immediate problem is that Solaris domU's have "0" for dev for the
> >first disk. So it's presumably matched on the hex re in util/blkif.py,
> >returning 0 and failing this incorrect check. There are other  
> >problems:
> 
> I don't know about the other stuff, but changing the check to
> 
> if devid is None:
> 
> should solve your immediate problem, right?

Yes, but only by chance.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel