[Xen-devel] Linux-specific blkif.py change

[John Levon <levon@xxxxxxxxxxxxxxxxx>]

Changeset 11831:f5321161c649 has broken non-Linux domUs with this
change:

         devid = blkif.blkdev_name_to_number(dev)
+        if not devid:
+            raise VmError('Unable to find number for device (%s)' % (dev))
+

The immediate problem is that Solaris domU's have "0" for dev for the
first disk. So it's presumably matched on the hex re in util/blkif.py,
returning 0 and failing this incorrect check. There are other problems:

1) util/blkif.py logs to xend-debug.log if the stat() fails. This is
needlessly chatty, and indicates there's some kind of error, when there
is not.

2) util/blkif.py has a load of Linux gook for getting the device
numbers. Luckily Solaris has a completely different naming scheme, but
wouldn't this go horribly wrong if a domU just happened to use the same
name, different device number?

It's not clear to us why Linux even needs to do this?

For now I think the change needs backing out so non-Linux domU's can
work again. I'm not sure of a better fix; suggestions welcome.

regards
john

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel