WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] RE: clear redunadant IRQ disable

To: "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] RE: clear redunadant IRQ disable
From: "Dong, Eddie" <eddie.dong@xxxxxxxxx>
Date: Tue, 31 Oct 2006 20:39:06 +0800
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, "Huang, Xinmei" <xinmei.huang@xxxxxxxxx>
Delivery-date: Thu, 02 Nov 2006 13:53:51 -0800
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: Acbwn3GTeQX7YqjuSrWHsAKaEOOOQwANzaogAF+2ZZACaGUm0AAEkMSwAAbrrDAAAklb1wAAHUJQACYey+AAAlAZYgAGQZtw
Thread-topic: clear redunadant IRQ disable
Keir Fraser wrote:
> On 31/10/06 08:38, "Dong, Eddie" <eddie.dong@xxxxxxxxx> wrote:
> 
>> Clear the redundant code in vmx_load_cr2 and use got "%EBX" for
>> current vcpu pointer.
> 
> vmx_load_cr2() simplification is worthwhile but I'm not sure about
> 'vcpu *' as a parameter to various functions. It's cheap to compute
> current and it's actually confusing sometimes whether a function
> takes an arbitrary vcpu or whether it is allowed to assume current.
> This is made obvious if the function grabs current for itself.
> 
Fine too. So you will delete the IRQ disable line, right :-)
Eddie

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] RE: clear redunadant IRQ disable, Dong, Eddie <=