WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Re: [Patch] Fix blktap to work with a bootloader

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] Re: [Patch] Fix blktap to work with a bootloader
From: Ewan Mellor <ewan@xxxxxxxxxxxxx>
Date: Tue, 10 Oct 2006 16:26:53 +0100
Cc: Julian Chesterfield <jac90@xxxxxxxxx>, "xen-devel@xxxxxxxxxxxxxxxxxxx" <xen-devel@xxxxxxxxxxxxxxxxxxx>, Andrew Warfield <andrew.warfield@xxxxxxxxxxxx>
Delivery-date: Tue, 10 Oct 2006 08:28:22 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C1517466.24A9%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1160492162.5951.9.camel@xxxxxxxxxxxxxxxxxxxxx> <C1517466.24A9%Keir.Fraser@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.9i
On Tue, Oct 10, 2006 at 04:01:42PM +0100, Keir Fraser wrote:

> On 10/10/06 15:56, "Stephen C. Tweedie" <sct@xxxxxxxxxx> wrote:
> 
> > btw, is the process of merging patches from email being done completely
> > manually?  git certainly has really good pull-from-email scripts that
> > avoid this sort of oversight, but I'm not sure hg is quite so well
> > equipped.
> 
> Usually patches are applied as a whole unit using 'patch', even if they have
> to be manually extracted from the email. Looks like Andy might have done
> this one by hand and got it wrong!

On that note, _please_ can people submit patches

  1. as attachments,
  2. with a text/plain MIME type, and preferably
  3. using hg export with a decent comment and a Signed-off-by: line in place.

It makes life a lot easier!

If your mailer doesn't do text/plain attachments properly, and for some reason
you still want to use such a broken heap of four-ex, then the next best thing
is plain-text inline in the message (because most people can't review patches
very easily if your mailer has sent it as an octet-stream).

Thanks,

Ewan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel