This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] x86-64: suppress some unneeded side effects of -

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>, Jan Beulich <jbeulich@xxxxxxxxxx>, <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] x86-64: suppress some unneeded side effects of -fPIC
From: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Date: Wed, 13 Sep 2006 14:20:06 +0100
Delivery-date: Wed, 13 Sep 2006 06:20:41 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <C12DC306.12EA%Keir.Fraser@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Thread-index: AcbXNk+UjlGesUMpEduJngAX8io7RQAAGJZvAAAoiDI=
Thread-topic: [Xen-devel] [PATCH] x86-64: suppress some unneeded side effects of -fPIC
User-agent: Microsoft-Entourage/

On 13/9/06 14:15, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

>> It does stack okay on top of command-line option? I'm assuming so, and I'll
>> check in this new patch in addition to the one I already committed.
> Actually, another question first: if gcc does not understand the pragma will
> it silently ignore it? Then we could get rid of check for GNUC>3, and we
> could get rid of -fvisibility=hidden too.

Answered my own question. We need the check. So I'll apply the patch as is.

 -- Keir

Xen-devel mailing list