Re: [Xen-devel] [PATCH] x86-64: suppress some unneeded side effects of -fPIC

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 13/9/06 14:12, "Keir Fraser" <Keir.Fraser@xxxxxxxxxxxx> wrote:

>> Hmm, bad luck, this time I had hoped it'll take you a little longer to commit
>> it, as we've found a better solution: Using #pragma GCC visibility, *all*
>> data references benefit, not just the ones to objects defined in the same
>> translation unit. However, as this now is a header file change, detection
>> logic cannot be used as nicely, so I guess we want to keep the previous
>> change and add this one on top.
>> 
>> Signed-off-by: Jan Beulich <jbeulich@xxxxxxxxxx>
> 
> It does stack okay on top of command-line option? I'm assuming so, and I'll
> check in this new patch in addition to the one I already committed.

Actually, another question first: if gcc does not understand the pragma will
it silently ignore it? Then we could get rid of check for GNUC>3, and we
could get rid of -fvisibility=hidden too.

 -- Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel