Re: [Xen-devel] [PATCH] clear cpu_eoi_map bit on flush

[Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>]

On 23/8/06 4:31 am, "Steven Rostedt" <srostedt@xxxxxxxxxx> wrote:

> When cpu_eoi_map is set, neither flush_all_pending_eoi nor
> flush_read_eoi clear the cpu_eoi_map bit.  So I hit the BUG_ON.
> 
> I haven't put too much effort into this patch, but it seems that it gets
> me past the problem I was having. (I'm now crashing later on in Dom0 but
> that's my problem :)
> 
> I added the ASSERT because it seems that that bit should be set
> regardless. Thinking that pending_eoi_sp should be in sync with
> cpu_eoi_map (but I could be wrong on this).

That part of the unbind routine is actually much more heavyweight than we
really need, so I cut it back and added a more detailed comment for future
reference. I think your patch was fine though, except that you forgot to add
the missing 'peoi[sp].ready = 0'.

 Thanks!
 Keir



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel