WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH 0/6] xen,xend,tools: Add NUMA support to Xen

To: Ryan Harper <ryanh@xxxxxxxxxx>, xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH 0/6] xen,xend,tools: Add NUMA support to Xen
From: Tristan Gingold <Tristan.Gingold@xxxxxxxx>
Date: Tue, 1 Aug 2006 11:29:13 +0200
Delivery-date: Tue, 01 Aug 2006 02:25:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060731190958.GI1694@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <20060731190958.GI1694@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.5
Le Lundi 31 Juillet 2006 21:09, Ryan Harper a écrit :
> I've respun the NUMA patches against 10874 and I'm re-submitting them
> with the optimizations mentioned [1]previously on the list.  There was a
> request to see the overhead on non-numa/single-node machines.  I've
> re-run those benchmarks (ballooning up from small mem to multi-gig) as
> well as timing the initially domain increase_reservation time to gauge
> the overhead when allocating from the heap.
Hi,

one more comment:
in dom0_ops.c:
+    case DOM0_AVAILHEAP:
+    {
+        ret = -EINVAL;
+        if ( op->u.availheap.node >= num_online_nodes() )
+            break;
+        if ( op->u.availheap.zone >= NR_ZONES )
+            break;
+
+        /* indicate the number of zones/nodes queried.
+         * NB: -1 is wild card for all zones/nodes */
+        ( op->u.availheap.zone < 0 ) ?
+            (op->u.availheap.nr_zones=NR_ZONES) :
+            (op->u.availheap.nr_zones=1);
+
+        ( op->u.availheap.node < 0 ) ?
+            (op->u.availheap.nr_nodes=num_online_nodes()) :
+            (op->u.availheap.nr_nodes=1);

I am not sure this corresponds to the Xen style.
Either use an if statement or a variable assignment:
op->u.availheap.nr_nodes = ( op->u.availheap.node < 0 ?)  num_online_nodes() : 
1;

Tristan.

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel