WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH][RESEND]Xenoprof passive domain support

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] [PATCH][RESEND]Xenoprof passive domain support
From: "Ray Bryant" <raybry@xxxxxxxxxxxxxxxxx>
Date: Wed, 28 Jun 2006 15:50:21 -0500
Cc: "Yang, Xiaowei" <xiaowei.yang@xxxxxxxxx>, "Santos, Jose Renato G" <joserenato.santos@xxxxxx>, "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Delivery-date: Wed, 28 Jun 2006 13:54:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <E42673822206994F8293A048721B91A50612EA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <E42673822206994F8293A048721B91A50612EA@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.8
On Tuesday 27 June 2006 00:55, Yang, Xiaowei wrote:
> Keir,
> After several discussions with Renato, I remade the patch, which is
> against c/s 10428. The main functionality remains the same, while it
> takes more care of passive domain status cleanup, adopts a more
> efficient lockup mechanism, a more consistent interface which is used by
> active domain, and does some improvements of code style.
>
> Thanks,
> Xiaowei

Xiaowei,

Hmmm... When I apply your patch to 10428, then try to compile 
linux-2.6.16.13-xen, it fails with the following:

  CC      arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o
arch/i386/oprofile/xenoprof.c: In function `xenoprof_handle_passive':
arch/i386/oprofile/xenoprof.c:160: error: `IGNORED_PC' undeclared (first use 
in this function)
arch/i386/oprofile/xenoprof.c:160: error: (Each undeclared identifier is 
reported only once
arch/i386/oprofile/xenoprof.c:160: error: for each function it appears in.)
arch/i386/oprofile/xenoprof.c:160: error: `CPU_MODE_PASSIVE_START' undeclared 
(first use in this function)
arch/i386/oprofile/xenoprof.c:162: error: `CPU_MODE_PASSIVE_STOP' undeclared 
(first use in this function)
arch/i386/oprofile/xenoprof.c: At top level:
arch/i386/oprofile/xenoprof.c:449: error: unknown field `set_passive' 
specified in initializer
arch/i386/oprofile/xenoprof.c:449: warning: initialization from incompatible 
pointer type
make[1]: *** [arch/x86_64/oprofile/../../i386/oprofile/xenoprof.o] Error 1

Any suggestions?
-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)



_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel