|   | 
      | 
  
  
      | 
      | 
  
 
     | 
    | 
  
  
     | 
    | 
  
  
    |   | 
      | 
  
  
    | 
         
xen-devel
Re: [Xen-devel] [PATCH][HVM] Removing 1:1 mapping from qemu-dm
 
On 28 Jun 2006, at 20:51, Nakajima, Jun wrote:
 
Since it's just get/put_page_from_l1e I think we should just duplicate
the required bits in the shadow code. Could the required parts be
merged into shadow_get/put_page_from_l1e()? For example, non of the
I/O-page mapping stuff is needed at all yet. We could for now BUG_ON
!valid_mfn() and flags in L1_DISALLOW_MASK.
 
 
Yes, we can merge the required parts into
shadow_get/put_page_from_l1e().
We still need to change get/put_page_from_l1e to prevent qemu-dm from
changing type_info, but we don't need to add an extra parameter that
way.
 
 
 Ah yes. Testing for whether the page owner is shadow_mode_refcount 
should do? We can add a comment to explain why we do the test.
 
Could you split your original patch into the updated changes to shadow
mode, and a separate patch for the actual mapcache logic?
 
 
I'll do that.
 
 
Thanks!
 -- Keir
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel
 
 |   
 
 | 
    | 
  
  
    |   | 
    |