WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] Re: [patch] ACM ops interface

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: [Xen-devel] Re: [patch] ACM ops interface
From: Reiner Sailer <sailer@xxxxxxxxxx>
Date: Thu, 8 Jun 2006 17:25:30 -0400
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, hollisb@xxxxxxxxxx, xen-ppc-devel <xen-ppc-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 08 Jun 2006 14:26:42 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <f194ff98faaa09da569179f16e76d7ac@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx

Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> wrote on 06/08/2006 02:42:10 PM:

>
> On 8 Jun 2006, at 19:32, Hollis Blanchard wrote:
>
> >>> First, it isn't using XEN_GUEST_HANDLEs where it should (i.e. when
> >> using
> >>> pointers in the interface). What's a little scary is that because
> >> it's
> >>> using void* everywhere, we didn't get any compiler warnings (if
> >> you're
> >>> passing buffers, maybe 'unsigned char *' would be a better type?).
> >>
> >> Keir responded to this point already
> >
> > I didn't see that, actually.
>
> Yeah, I don't think I did.
>
> Anyway, should I take Hollis's patch or do you want it worked on some
> more?
>
> As for copy_to/from_user sleeping, they don't sleep in Xen but it would
> be nice to avoid putting it in a locked region anyway in case we want
> to do anything clever in future. I may start asserting that in debug
> builds.
>
>   -- Keir
>

Makes sense.

If Hollis doesn't include it in his patch, then I will address it next week.

Reiner
_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel