WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] Make xentrace hypercall a bit more sane

To: George Dunlap <dunlapg@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Make xentrace hypercall a bit more sane
From: Rob Gardner <rob.gardner@xxxxxx>
Date: Thu, 01 Jun 2006 14:24:33 -0600
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
Delivery-date: Thu, 01 Jun 2006 13:25:08 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <de76405a0606011317qe1fed70u1eb52e6046d32246@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <de76405a0606011317qe1fed70u1eb52e6046d32246@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird 1.5.0.2 (Windows/20060308)
George Dunlap wrote:
xentrace, setsize and the hypervisor don't seem to be on the same
page.  If tracing is not enabled, the hypercall will only allow
TBUF_SET_SIZE and TBUF_ENABLE.  However, set_size calls TBUF_GET_INFO,
and xentrace wants to call TBUF_SET_EVT_MASK and TBUF_SET_CPU_MASK
before calling TBUF_ENABLE.

I don't see any reason not to call SET_*_MASK and GET_INFO if tracing
is not enabled.    If the buffer hasn't been allocated yet, GET_INFO
should just return something invalid in the mfn field.  Anyone calling
should check this value.


Sounds benign enough. I never liked the behavior of disallowing the get_info call.

Rob




_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>