 Home |
Products |
Support |
Community |
News |
xen-devel
[Xen-devel] [PATCH] Make xentrace hypercall a bit more sane
| To: | xen-devel@xxxxxxxxxxxxxxxxxxx |
|---|---|
| Subject: | [Xen-devel] [PATCH] Make xentrace hypercall a bit more sane |
| From: | "George Dunlap " <dunlapg@xxxxxxxxx> |
| Date: | Thu, 1 Jun 2006 16:17:03 -0400 |
| Delivery-date: | Thu, 01 Jun 2006 13:17:31 -0700 |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:sender:to:subject:mime-version:content-type:x-google-sender-auth; b=nWMiX++RskbOvea3bETMkWcOX5i/VJnYBj6Z/cqQsCF8hFD9aCLIVF+bDifz7pxzW7DBYHOVO3kgZYQPhEKUryeuOsUYc0TLKIymQ46mAKUj447p2eeCppw4YBlkz3UI3pmapK2x8Q3hCqNQ8sWjgwcak5ObEfjLkzh7dZ4+pXg= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxx |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
xentrace, setsize and the hypervisor don't seem to be on the same page. If tracing is not enabled, the hypercall will only allow TBUF_SET_SIZE and TBUF_ENABLE. However, set_size calls TBUF_GET_INFO, and xentrace wants to call TBUF_SET_EVT_MASK and TBUF_SET_CPU_MASK before calling TBUF_ENABLE. I don't see any reason not to call SET_*_MASK and GET_INFO if tracing is not enabled. If the buffer hasn't been allocated yet, GET_INFO should just return something invalid in the mfn field. Anyone calling should check this value. Comments? -George
_______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] Daily Xen Builds, David F Barrera |
|---|---|
| Next by Date: | Re: [Xen-devel] [PATCH] Make xentrace hypercall a bit more sane, Rob Gardner |
| Previous by Thread: | [Xen-devel] Daily Xen Builds, David F Barrera |
| Next by Thread: | Re: [Xen-devel] [PATCH] Make xentrace hypercall a bit more sane, Rob Gardner |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
