This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [RFC][PATCH] Allow privcmd to support the _compat hypercalls

To: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] [RFC][PATCH] Allow privcmd to support the _compat hypercalls
From: Anthony Liguori <aliguori@xxxxxxxxxx>
Date: Thu, 25 May 2006 12:53:24 -0500
Delivery-date: Thu, 25 May 2006 10:54:05 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Thunderbird (X11/20060522)
Hi Keir,

I was encountering an odd error where Xend was tossing an EINVAL on xc_evtchn_alloc_unbound. After tracking it down, it turns out that this was because of an older userspace that was using the _compat version of the hypercalls.

Since the hypervisor still supports these calls, is there a compelling reason to not allow privcmd to expose these calls? If not, please apply the following patch.


Anthony Liguori
# HG changeset patch
# User Anthony Liguori <anthony@xxxxxxxxxxxxx>
# Node ID daa038c99299f3770f6724b7e23f44451b36da3e
# Parent  ad33b3882867f6ab4466383129aa3827c64508d3
Allow compat hypercalls to be made (to support older userspaces).

Signed-off-by: Anthony Liguori <aliguori@xxxxxxxxxx>

diff -r ad33b3882867 -r daa038c99299 
--- a/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c        Wed May 24 
19:41:47 2006 +0100
+++ b/linux-2.6-xen-sparse/drivers/xen/privcmd/privcmd.c        Thu May 25 
12:48:32 2006 -0500
@@ -267,6 +267,9 @@ static int __init privcmd_init(void)
        set_bit(__HYPERVISOR_mmuext_op,        hypercall_permission_map);
        set_bit(__HYPERVISOR_xen_version,      hypercall_permission_map);
        set_bit(__HYPERVISOR_sched_op,         hypercall_permission_map);
+       set_bit(__HYPERVISOR_sched_op_compat,  hypercall_permission_map);
+       set_bit(__HYPERVISOR_event_channel_op_compat, hypercall_permission_map);
+       set_bit(__HYPERVISOR_physdev_op_compat, hypercall_permission_map);
        privcmd_intf = create_xen_proc_entry("privcmd", 0400);
        if (privcmd_intf != NULL)
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>
  • [Xen-devel] [RFC][PATCH] Allow privcmd to support the _compat hypercalls, Anthony Liguori <=