WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Xenoprof: getting Oprofile out of timer mode?

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: Re: [Xen-devel] Xenoprof: getting Oprofile out of timer mode?
From: "Ray Bryant" <raybry@xxxxxxxxxxxxxxxxx>
Date: Wed, 24 May 2006 12:19:38 -0500
Cc: Gitika Aggarwal <gitika@xxxxxxxxx>, Andrei Lifchits <alifchit@xxxxxxxxx>, "Santos, Jose Renato G" <joserenato.santos@xxxxxx>
Delivery-date: Wed, 24 May 2006 10:20:23 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <6C21311CEE34E049B74CC0EF339464B9645430@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <6C21311CEE34E049B74CC0EF339464B9645430@xxxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.8
On Wednesday 24 May 2006 02:02, Santos, Jose Renato G wrote:
> According to the Intel manual cpu_model 6 has the same
> perf counters as the other models of the p4 family.
> Thus, the patch seems the right fix, except
> that it would be better to use (cpu_model > 6)
> instead of (cpu_model > 7).
> Keir is right, oprofile should have the same problem
> in native Linux. I guess we could submit a similar
> patch for oprofile to the linux kernel mailing list.
>
> Renato
>

Ah, no, you need to return 1 for success.   If the current cpu_model is 6, 
then "if (cpu_model > 6)" will return 0 and xenoprof/oprofile will remain in 
timer mode. 

-- 
Ray Bryant
AMD Performance Labs                   Austin, Tx
512-602-0038 (o)                 512-507-7807 (c)


_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel