This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


[Xen-devel] [PATCH] (corrected) 01_enforce_dom0_cpus_basic_pos reset vcp

To: xen-devel@xxxxxxxxxxxxxxxxxxx
Subject: [Xen-devel] [PATCH] (corrected) 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
From: Paul Larson <pl@xxxxxxxxxx>
Date: Tue, 23 May 2006 15:40:14 -0500
Delivery-date: Tue, 23 May 2006 15:46:30 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <20060523194904.GS16876@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200605231432.05451.pl@xxxxxxxxxx> <20060523194904.GS16876@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: KMail/1.9.1
On Tuesday 23 May 2006 14:49, Ryan Harper wrote:
> * Paul Larson <pl@xxxxxxxxxx> [2006-05-23 14:33]:
> > If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not
> > get restored causing subsequent boots to come up with only a single vcpu
> > on dom0.
> Though I've never seen this mentioned on the list, I thought we wanted
> to leave the system in the failed state if a test failed?  That's
> certainly debatable.  Thoughts?
Generally, that's probably a good rule but in this case it's better to go with 
the FAIL() output and put it back to a reasonable state because  the altered 
state can persist not only out the end of the test run, but across xend 
restarts and even reboots.  The reason this came up is because a bug was 
filed where a few systems were only showing one cpu in /proc/cpuinfo, but 
they were configured for smp and had previously booted with all their 

> White-space damage.
Doh! Fixed version attached.
 01_enforce_dom0_cpus_basic_pos.py |   21 +++++++++++----------
 1 file changed, 11 insertions(+), 10 deletions(-)
Signed-off-by: Paul Larson <pl@xxxxxxxxxx>

Attachment: 01_enforce.patch
Description: Text Data

Attachment: pgpVVkPM7o7pM.pgp
Description: PGP signature

Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>