WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] [PATCH] 01_enforce_dom0_cpus_basic_pos reset vcpu count

To: Paul Larson <pl@xxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 01_enforce_dom0_cpus_basic_pos reset vcpu count on failures.
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Tue, 23 May 2006 14:49:04 -0500
Cc: xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Tue, 23 May 2006 12:49:29 -0700
Envelope-to: www-data@xxxxxxxxxxxxxxxxxx
In-reply-to: <200605231432.05451.pl@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <200605231432.05451.pl@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Paul Larson <pl@xxxxxxxxxx> [2006-05-23 14:33]:
> If 01_enforce_dom0_cpus_basic_pos fails, the vcpu count for dom0 does not get 
> restored causing subsequent boots to come up with only a single vcpu on dom0.

Though I've never seen this mentioned on the list, I thought we wanted
to leave the system in the failed state if a test failed?  That's
certainly debatable.  Thoughts?

> -    num_online = int(getDomInfo("Domain-0", "VCPUs"))
> -    if num_online == dom0_online_vcpus:
> -        break
> -    time.sleep(1)
> +   num_online = int(getDomInfo("Domain-0", "VCPUs"))
> +   if num_online == dom0_online_vcpus:
> +       break
> +   time.sleep(1)

White-space damage.



-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>