RE: [Xen-devel] phys_basetab might be used uninitialized in domain.c

["Li, Xin B" <xin.b.li@xxxxxxxxx>]

>Hello,
>
> In xen-unstable [changeset 8920], gcc warns me that phys_basetab
>variable might be used uninitialized in arch/x86/domain.c
>
> So is it ok to write:
>
>    414     if ( shadow_mode_refcounts(d) )
>    415     {
>    416         if ( 
>!get_page(mfn_to_page(phys_basetab>>PAGE_SHIFT), d) )
>    417         {
>    418             destroy_gdt(v);
>    419             return -EINVAL;
>    420         }

phys_basetab should be initialized to INVALID_MFN, and check if it is
valid before use.
Also, this code causes AP of SMP VMX guest can't boot, I will send a
fix.
thanks
-Xin

>
> in arch_set_info_guest() knowing that phys_basetab can be 
>unset at this
>point.
>
>Hope this help,
>Guillaume
>
>_______________________________________________
>Xen-devel mailing list
>Xen-devel@xxxxxxxxxxxxxxxxxxx
>http://lists.xensource.com/xen-devel
>

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel