WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

[Xen-devel] phys_basetab might be used uninitialized in domain.c

To: xen-devel@xxxxxxxxxxxxxxxxxxx <xen-devel@xxxxxxxxxxxxxxxxxxx>
Subject: [Xen-devel] phys_basetab might be used uninitialized in domain.c
From: Guillaume Thouvenin <guillaume.thouvenin@xxxxxxx>
Date: Wed, 22 Feb 2006 09:06:21 +0100
Delivery-date: Wed, 22 Feb 2006 11:06:16 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Organization: Bull S.A.
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
Hello,

 In xen-unstable [changeset 8920], gcc warns me that phys_basetab
variable might be used uninitialized in arch/x86/domain.c

 So is it ok to write:

    414     if ( shadow_mode_refcounts(d) )
    415     {
    416         if ( !get_page(mfn_to_page(phys_basetab>>PAGE_SHIFT), d) )
    417         {
    418             destroy_gdt(v);
    419             return -EINVAL;
    420         }

 in arch_set_info_guest() knowing that phys_basetab can be unset at this
point.

Hope this help,
Guillaume

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

<Prev in Thread] Current Thread [Next in Thread>