WARNING - OLD ARCHIVES

This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
   
 
 
Xen 
 
Home Products Support Community News
 
   
 

xen-devel

Re: [Xen-devel] Daily Xen Builds

To: Anthony Liguori <aliguori@xxxxxxxxxx>
Subject: Re: [Xen-devel] Daily Xen Builds
From: Ryan Harper <ryanh@xxxxxxxxxx>
Date: Mon, 10 Oct 2005 16:28:34 -0500
Cc: Ian Pratt <m+Ian.Pratt@xxxxxxxxxxxx>, David F Barrera <dfbp@xxxxxxxxxx>, xen-devel <xen-devel@xxxxxxxxxxxxxxxxxxx>, Dan Smith <danms@xxxxxxxxxx>
Delivery-date: Mon, 10 Oct 2005 21:26:01 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <434ADB55.8050609@xxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <1128978545.12366.15.camel@dbarrera_tp> <434ADB55.8050609@xxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/1.5.6+20040907i
* Anthony Liguori <aliguori@xxxxxxxxxx> [2005-10-10 16:22]:
> David F Barrera wrote:
> 
> >Test changeset:
> >
> >changeset:   7293:0f33cbec4e36
> >tag:         tip
> >user:        emellor@ewan
> >date:        Mon Oct 10 13:06:14 2005 +0100
> >summary:     This patch fixes an error in the xm create path when the
> >
> >Last known good changeset for all platforms: 7069:a172340ae3f3
> > 
> >
> <snip>
> 
> >xm-test: This suite provides a framework for testing the Xen userspace
> >tools.
> >
> >SUMMARY:
> >           Platform | PASS | FAIL | XPASS | XFAIL |
> >---------------------+------+------+-------+-------+
> >             FC3pae |   64 |   30 |     0 |     1 |
> >hs20.1.sles9-x86_64 |   62 |   32 |     0 |     1 |
> >hs20.2.sles9-x86_64 |   62 |   32 |     0 |     1 |
> >    hs20.fc4_x86_64 |   63 |   31 |     0 |     1 |
> >    x235sles9nonpae |   64 |   28 |     0 |     1 |
> >         x305rh4pae |   63 |   30 |     0 |     1 |
> >         x335fc4pae |   53 |   39 |     0 |     1 |
> >
> > 
> >
> This is a lot of failures.
> 
> Is it perhaps wise, nearing 3.0, that we adopt a policy of running the 
> various test suites on code before it gets pushed to the public tree?  
> This seems like requiring passing on xm-test a sane thing to do for the 
> tools related changes.  Is there anything that needs to be done to the 
> test suites to make this less painful for the committers?
> 
> Just to clarify, I'm suggesting that all changes should be checked 
> (external patches or Cambridge pushes) against the testsuites before 
> committing.  Just seems like it would be a good way to ensure that we 
> avoid regressing as we near 3.0 release.
> 
> I don't think anyone is particularly at fault for the recent 
> regressions, I just think it's time we adopt a more rigorious commit policy.

I think this is a fantastic idea.  Certainly worth running a before and
after patch applied and compare results.

-- 
Ryan Harper
Software Engineer; Linux Technology Center
IBM Corp., Austin, Tx
(512) 838-9253   T/L: 678-9253
ryanh@xxxxxxxxxx

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel