Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0

[aq <aquynh@xxxxxxxxx>]

On 6/26/05, Reiner Sailer <sailer@xxxxxxxxxx> wrote:
> > Message: 7
> > Date: Sat, 25 Jun 2005 20:39:20 -0500
> > From: aq <aquynh@xxxxxxxxx>
> > Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
> > To: Stefan Berger <stefanb@xxxxxxxxxx>
> > Cc: xen-devel@xxxxxxxxxxxxxxxxxxx
> > Message-ID: <9cde8bff05062518394eab73cb@xxxxxxxxxxxxxx>
> > Content-Type: text/plain; charset=ISO-8859-1
> >
> > On 6/25/05, Stefan Berger <stefanb@xxxxxxxxxx> wrote:
> > > Hello!
> > >
> > > Attached is the patch that changes the default ssid from 0xffffffff to
> 0
> > > as discussed in previous emails.
> > >
> > > Signed-off-by: Reiner Sailer <sailer@xxxxxxxxxx>
> > > Signed-off-by: Stefan Berger <stefanb@xxxxxxxxxx>
> > >
> > >    Stefan
> > >
> >
> >
> >
> > +     for(j=0; j<= CWALL_MAX_SSIDREFS; j++)
> > +         if ((0 < j) &&( j <= CWALL_MAX_TYPES))
> > +             ssidrefs[j*CWALL_MAX_TYPES + j - 1] = htons(1);
> > +
> >
> > why dont you run the loop from j=1?
> 
> 
> because row j=0 is the new default ssid and has no types set.
> We start with row j=1 and set the "diagonal" types to one.

i meant in the above loop, if start from j=1 you can eliminate the
check (if 0<j), because in case j=0 you does nothing.

regards,
aq

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel