This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0

To: Mark Williamson <mark.williamson@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] 1 of 2: default ssid to 0
From: aq <aquynh@xxxxxxxxx>
Date: Sat, 25 Jun 2005 21:18:39 -0500
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Stefan Berger <stefanb@xxxxxxxxxx>
Delivery-date: Sun, 26 Jun 2005 02:17:35 +0000
Domainkey-signature: a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=YCtNIILug+d48qjdRUzyMgSF2OaTBcIGlyPkLOlOPX/BGRwmObQCdOlIkaE649ZHk94l1sslxsNCzLoM0B7CHf+AR+yRn6DadfLqrAQp8t4lIJlRriqT9IecHTaZme/IHWmnVBzJoCKNIzb/QaW0Wrlid7OyW+biS5kyORf6RN0=
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <200506260249.18338.mark.williamson@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <OFC7293D35.7F7078B7-ON8525702B.00641461-8525702B.006592BC@xxxxxxxxxx> <9cde8bff0506251845587fb3b9@xxxxxxxxxxxxxx> <200506260249.18338.mark.williamson@xxxxxxxxxxxx>
Reply-to: aq <aquynh@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On 6/25/05, Mark Williamson <mark.williamson@xxxxxxxxxxxx> wrote:
> On Sunday 26 June 2005 02:45, aq wrote:
> > looks like this patch (and also many other codes in the tree) mixed of
> > tabs and spaces for indentation :-(. especially this code will be in
> > mainline in the future.
> >
> > is it time for us to have a official *coding style guide*, and all the
> > patches sent in must comply with the guide in order to be picked up
> > ???
> It seems sensible for XenLinux code to follow the Linux CodingStyle document
> (although I'm not sure all the drivers do this yet).
> Xen-related C code that isn't destined for the Linux kernel itself has a
> different coding style:
> * we indent in blocks of 4 spaces and don't use tabs
> * { and } are always on a new line, unlike K&R style
> * we put a space between an if and the open parenthesis, and between the
> parentheses and the boolean: if ( murble )

i think it is very bad idea to have 2 coding styles for code in kernel
and out of kernel. because people work on all those code must always
remember to adjust the editor configuration, depend on the code in or
out of kernel, which is a nightmare :-(

how about this simple guide?
- C code complies Linux kernel coding style
- Python code can use (4) spaces for indentation (as in currently) 


Xen-devel mailing list