This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix vnc-dryrun option interaction

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix vnc-dryrun option interaction
From: Arun Sharma <arun.sharma@xxxxxxxxx>
Date: Thu, 23 Jun 2005 13:30:05 -0700
Cc: George Washington Dunlap III <dunlapg@xxxxxxxxx>, xen-devel List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 20:29:09 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <42BB1734.80903@xxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <Pine.LNX.4.60.0506231018540.4707@xxxxxxxxxxxxxxxxxxxxxx> <670517d5e836a3caaa16706e6fb84145@xxxxxxxxxxxx> <42BAE9FC.2030103@xxxxxxxxx> <e4f3c09a3f981e2c47be9a0d9d60163c@xxxxxxxxxxxx> <42BB1734.80903@xxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
Arun Sharma wrote:
Keir Fraser wrote:

On 23 Jun 2005, at 17:57, Arun Sharma wrote:

Please apply this patch. It fixes two problems:

The patch is missing. :-)

I meant the patch George posted :)

There's a problem with that patch.

I think this patch is better. With George's patch (and my original patch) xm create -n shows (vnc 0), even when vnc=1 in the config file.

diff -r 3b939e817833 tools/python/xen/xm/create.py
--- a/tools/python/xen/xm/create.py     Thu Jun 23 16:38:32 2005
+++ b/tools/python/xen/xm/create.py     Thu Jun 23 13:30:06 2005
@@ -545,7 +545,7 @@
     """If vnc was specified, spawn a vncviewer in listen mode
     and pass its address to the domain on the kernel command line.
-    if not vals.vnc: return
+    if not vals.vnc or vals.dryrun: return
     vnc_display = choose_vnc_display()
     if not vnc_display:
         opts.warn("No free vnc display")
Xen-devel mailing list
<Prev in Thread] Current Thread [Next in Thread>