This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] Fix vnc-dryrun option interaction

To: Keir Fraser <Keir.Fraser@xxxxxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] Fix vnc-dryrun option interaction
From: Arun Sharma <arun.sharma@xxxxxxxxx>
Date: Thu, 23 Jun 2005 09:57:32 -0700
Cc: George Washington Dunlap III <dunlapg@xxxxxxxxx>, xen-devel List <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Thu, 23 Jun 2005 16:56:38 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <670517d5e836a3caaa16706e6fb84145@xxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <Pine.LNX.4.60.0506231018540.4707@xxxxxxxxxxxxxxxxxxxxxx> <670517d5e836a3caaa16706e6fb84145@xxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mozilla Thunderbird 1.0.2 (Windows/20050317)
Keir Fraser wrote:
On 23 Jun 2005, at 15:23, George Washington Dunlap III wrote:

A patch that was applied yesterday tried to turn the vnc option off if dryrun was set. Unfortunately, the way it was actually coded turned vnc ON if dryrun was not set! I think this patch should fix it (someone who actually uses vnc & dryrun should test it, though).


That patch was originally from Arun Sharma at Intel. I've cc'ed him.

Please apply this patch. It fixes two problems:

- vnc shouldn't be turned on by default (I didn't spot it because I usually have VNC on)

- If it's a boolean, its stringified version seen by xend would be "True" or "False". An integer is easier to parse in xend. A patch that I have in my queue expects it to be an integer.


Xen-devel mailing list