 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [patch] pae: build fix
| To: | Gerd Knorr <kraxel@xxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [patch] pae: build fix |
| From: | Keir Fraser <Keir.Fraser@xxxxxxxxxxxx> |
| Date: | Wed, 22 Jun 2005 15:51:13 +0100 |
| Cc: | xen-devel@xxxxxxxxxxxxxxxxxxx |
| Delivery-date: | Wed, 22 Jun 2005 14:46:12 +0000 |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <20050622140025.GA31707@bytesex> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <20050622140025.GA31707@bytesex> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 22 Jun 2005, at 15:00, Gerd Knorr wrote: The patch below is needed to make pae-enabled xen build. Not sure why the intpte_t cast was added and whenever it is a good idea to remove it. Problem is that PAGE_MASK is used to page-align both physical and virtual addresses, and the cast causes build failures for the virtual address case. I added the cast to ensure the mask was 64 bits wide, so that large physical addresses wouldn't get truncated to 32 bits when the mask is applied. I've fixed it to get the same effect a different way -- it's okay to have a narrower-type mask as long as it is signed (so it gets sign-extended if it has to be widened to 64 bits). -- Keir _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | [Xen-devel] [patch] pae: build fix, Gerd Knorr |
|---|---|
| Next by Date: | [Xen-devel] pickle_domptr and unpickle_domptr issue with >4GB, Nakajima, Jun |
| Previous by Thread: | [Xen-devel] [patch] pae: build fix, Gerd Knorr |
| Next by Thread: | [Xen-devel] pickle_domptr and unpickle_domptr issue with >4GB, Nakajima, Jun |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
