xen-devel

[Top] [All Lists]

[Xen-devel] [patch] pae: build fix

from [Gerd Knorr]

[Permanent Link][Original]

To:	xen-devel@xxxxxxxxxxxxxxxxxxx
Subject:	[Xen-devel] [patch] pae: build fix
From:	Gerd Knorr <kraxel@xxxxxxx>
Date:	Wed, 22 Jun 2005 16:00:25 +0200
Delivery-date:	Wed, 22 Jun 2005 14:04:00 +0000
Envelope-to:	www-data@xxxxxxxxxxxxxxxxxxx
List-help:	<mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id:	Xen developer discussion <xen-devel.lists.xensource.com>
List-post:	<mailto:xen-devel@lists.xensource.com>
List-subscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe:	<http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
Sender:	xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent:	Mutt/1.5.9i

  Hi,

The patch below is needed to make pae-enabled xen build.  Not
sure why the intpte_t cast was added and whenever it is a good
idea to remove it.  Problem is that PAGE_MASK is used to
page-align both physical and virtual addresses, and the cast
causes build failures for the virtual address case.

Comments?

  Gerd

Index: xen/include/asm-x86/page.h
===================================================================
--- xen.orig/include/asm-x86/page.h     2005-06-20 12:45:29.000000000 +0200
+++ xen/include/asm-x86/page.h  2005-06-20 16:32:34.000000000 +0200
@@ -7,7 +7,8 @@
 #else
 #define PAGE_SIZE           (1 << PAGE_SHIFT)
 #endif
-#define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
+//#define PAGE_MASK           (~(intpte_t)(PAGE_SIZE-1))
+#define PAGE_MASK           (~(PAGE_SIZE-1))
 #define PAGE_FLAG_MASK      (~0U)
 
 #ifndef __ASSEMBLY__

_______________________________________________
Xen-devel mailing list
Xen-devel@xxxxxxxxxxxxxxxxxxx
http://lists.xensource.com/xen-devel

[More with this subject...]

<Prev in Thread]	Current Thread	[Next in Thread>
[Xen-devel] [patch] pae: build fix, Gerd Knorr <= Re: [Xen-devel] [patch] pae: build fix, Keir Fraser

Previous by Date:	[Xen-devel] [patch] pae: cmpxchg8b emulation, Gerd Knorr
Next by Date:	Re: [Xen-devel] [patch] pae: build fix, Keir Fraser
Previous by Thread:	[Xen-devel] [patch] pae: cmpxchg8b emulation, Gerd Knorr
Next by Thread:	Re: [Xen-devel] [patch] pae: build fix, Keir Fraser
Indexes:	[Date] [Thread] [Top] [All Lists]