 Home |
Products |
Support |
Community |
News |
xen-devel
Re: [Xen-devel] [PATCH] xs.h and xs_lib.h
| To: | Rusty Russell <rusty@xxxxxxxxxxxxxxx> |
|---|---|
| Subject: | Re: [Xen-devel] [PATCH] xs.h and xs_lib.h |
| From: | aq <aquynh@xxxxxxxxx> |
| Date: | Tue, 14 Jun 2005 13:46:54 +0900 |
| Cc: | Xen Dev <xen-devel@xxxxxxxxxxxxxxxxxxx> |
| Delivery-date: | Tue, 14 Jun 2005 04:46:04 +0000 |
| Domainkey-signature: | a=rsa-sha1; q=dns; c=nofws; s=beta; d=gmail.com; h=received:message-id:date:from:reply-to:to:subject:cc:in-reply-to:mime-version:content-type:content-transfer-encoding:content-disposition:references; b=qYsYq0oaDLA0FAFWzJb1Z2Go+z/1HpdtvqVUlYc6JAM/WNSPwdJJqmi+nnPj7VxkkIDoo8W+UpH0VJI56n5arPNo5h9Q9c3X1f4S30ssme6ICvDWYCDjT4O9YFS3yCfra4bk5L+BBpU+0cdmoZjSXjBSG2k9Uacb20pdjTUAQZk= |
| Envelope-to: | www-data@xxxxxxxxxxxxxxxxxxx |
| In-reply-to: | <1118709165.18549.5.camel@xxxxxxxxxxxxxxxxxxxxx> |
| List-help: | <mailto:xen-devel-request@lists.xensource.com?subject=help> |
| List-id: | Xen developer discussion <xen-devel.lists.xensource.com> |
| List-post: | <mailto:xen-devel@lists.xensource.com> |
| List-subscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe> |
| List-unsubscribe: | <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe> |
| References: | <9cde8bff050610013219cd249d@xxxxxxxxxxxxxx> <1118558205.31631.2.camel@xxxxxxxxxxxxxxxxxxxxx> <9cde8bff0506120814b2ebbe8@xxxxxxxxxxxxxx> <1118709165.18549.5.camel@xxxxxxxxxxxxxxxxxxxxx> |
| Reply-to: | aq <aquynh@xxxxxxxxx> |
| Sender: | xen-devel-bounces@xxxxxxxxxxxxxxxxxxx |
On 6/14/05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > On Mon, 2005-06-13 at 00:14 +0900, aq wrote: > > On 6/12/05, Rusty Russell <rusty@xxxxxxxxxxxxxxx> wrote: > > > On Fri, 2005-06-10 at 03:32 -0500, aq wrote: > > > > This patch moves declaration of xs_handle from xs.c to xs.h. > > > > > > No; why do this? It's opaque for a reason. Originally it was just an > > > int, but Keir insisted it be an opaque structure. Exposing it binds us > > > to the current structure again. > > > > > > > Besides, > > > > it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile > > > > uninstalled them when cleaning up. > > > > > > xs_lib.h should not be installed in /usr/include! > > > > i see that, but where should we put this header? > > Once the daemon and library are built, it's not necessary for anything. > i installed xs_lib.h because xs.h includes it. now we need to remove this and include xs_lib.h in other files as needed. later i will send in another patch to fix this, and revert the problem raised in last patch. regards, aq _______________________________________________ Xen-devel mailing list Xen-devel@xxxxxxxxxxxxxxxxxxx http://lists.xensource.com/xen-devel |
| <Prev in Thread] | Current Thread | [Next in Thread> |
|---|---|---|
| ||
| Previous by Date: | RE: [Xen-devel] Review needed for "commonisation"ofcommon/grant_table.c, Dong, Eddie |
|---|---|
| Next by Date: | [Xen-devel] RE: [PATCH] x86_64 entry.S cleanup, Nakajima, Jun |
| Previous by Thread: | Re: [Xen-devel] [PATCH] xs.h and xs_lib.h, Rusty Russell |
| Next by Thread: | Re: [Xen-devel] [PATCH] xs.h and xs_lib.h, Rusty Russell |
| Indexes: | [Date] [Thread] [Top] [All Lists] |
