This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [PATCH] xs.h and xs_lib.h

To: aq <aquynh@xxxxxxxxx>
Subject: Re: [Xen-devel] [PATCH] xs.h and xs_lib.h
From: Rusty Russell <rusty@xxxxxxxxxxxxxxx>
Date: Sun, 12 Jun 2005 16:36:45 +1000
Cc: Xen Dev <xen-devel@xxxxxxxxxxxxxxxxxxx>
Delivery-date: Sun, 12 Jun 2005 06:36:06 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <9cde8bff050610013219cd249d@xxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <9cde8bff050610013219cd249d@xxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
On Fri, 2005-06-10 at 03:32 -0500, aq wrote:
> This patch moves declaration of xs_handle from xs.c to xs.h.

No; why do this?  It's opaque for a reason.  Originally it was just an
int, but Keir insisted it be an opaque structure.  Exposing it binds us
to the current structure again.

> Besides,
> it installs xs.h and xs_lib.h to /usr/include, and gets top Makefile
> uninstalled them when cleaning up.

xs_lib.h should not be installed in /usr/include!

A bad analogy is like a leaky screwdriver -- Richard Braakman

Xen-devel mailing list