This is an archived copy of the Xen.org mailing list, which we have preserved to ensure that existing links to archives are not broken. The live archive, which contains the latest emails, can be found at http://lists.xen.org/
Home Products Support Community News


Re: [Xen-devel] [patch] predicate NX flag

To: "Nakajima, Jun" <jun.nakajima@xxxxxxxxx>
Subject: Re: [Xen-devel] [patch] predicate NX flag
From: "Scott Parish" <srparish@xxxxxxxxxx>
Date: Tue, 7 Jun 2005 20:47:16 +0000
Cc: xen-devel@xxxxxxxxxxxxxxxxxxx, Scott Parish <srparish@xxxxxxxxxx>
Delivery-date: Tue, 07 Jun 2005 21:29:19 +0000
Envelope-to: www-data@xxxxxxxxxxxxxxxxxxx
In-reply-to: <7F740D512C7C1046AB53446D37200173042FEC74@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
List-help: <mailto:xen-devel-request@lists.xensource.com?subject=help>
List-id: Xen developer discussion <xen-devel.lists.xensource.com>
List-post: <mailto:xen-devel@lists.xensource.com>
List-subscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=subscribe>
List-unsubscribe: <http://lists.xensource.com/cgi-bin/mailman/listinfo/xen-devel>, <mailto:xen-devel-request@lists.xensource.com?subject=unsubscribe>
References: <7F740D512C7C1046AB53446D37200173042FEC74@xxxxxxxxxxxxxxxxxxxxxxxxxxxx>
Sender: xen-devel-bounces@xxxxxxxxxxxxxxxxxxx
User-agent: Mutt/
On Tue, Jun 07, 2005 at 01:45:45PM -0700, Nakajima, Jun wrote:

> Scott Parish wrote:
> > the NX flag should only be set when its use is enabled.
> > 
> > sRp
> Rather than changing __PAGE_KERNEL, I think we should change set_p?d (?
> = g, u, m, e) like
> #define set_pmd(pmdptr, pmdval) xen_l2_entry_update(pmdptr, (pmdval)&
> __supported_pte_mask)

Working on a patch.. there are places that xen_l1_entry_update() is
called directly with __PAGE_KERNEL, should those be converted to a
set_pte, or should xen_l1_entry_update be updated instead of the macros,
or should '& __supported_pte_mask' be hardcoded into these places. I'd
prefer to just modify the xen_l?_entry_update()s

btw, __supported_PTE_mask seems an unfortunate name for a mask that gets
used for other pagetable levels.


Scott Parish
Signed-off-by: srparish@xxxxxxxxxx

Xen-devel mailing list